Skip to content

feat: (m-decompose) Module Prompt V3#770

Merged
jakelorocco merged 27 commits into
generative-computing:mainfrom
csbobby:tagparse
Apr 10, 2026
Merged

feat: (m-decompose) Module Prompt V3#770
jakelorocco merged 27 commits into
generative-computing:mainfrom
csbobby:tagparse

Conversation

@csbobby
Copy link
Copy Markdown
Contributor

@csbobby csbobby commented Apr 1, 2026 •
edited
Loading

Module Prompt V3

Description

  • Enhance the module execution and extraction robustness.

Implementation Checklist

Protocol Compliance

  • parts() returns list of constituent parts (Components or CBlocks)
  • format_for_llm() returns TemplateRepresentation or string
  • _parse(computed: ModelOutputThunk) parses model output correctly into the specified Component return type

Testing

  • Tests added to tests/components/
  • New code has 100% coverage
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@csbobby csbobby requested a review from a team as a code owner April 1, 2026 03:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@csbobby csbobby changed the title Tagparse feat (m decompose) Module Prompt V3 Apr 1, 2026
@csbobby csbobby changed the title feat (m decompose) Module Prompt V3 feat (m decompose): Module Prompt V3 Apr 1, 2026
@csbobby csbobby changed the title feat (m decompose): Module Prompt V3 feat: (m-decompose) Module Prompt V3 Apr 1, 2026
@github-actions github-actions Bot added the enhancement New feature or request label Apr 1, 2026
This was referenced Apr 1, 2026
Closed
Closed
@csbobby csbobby requested a review from a team as a code owner April 1, 2026 18:46
@csbobby csbobby removed the request for review from a team April 1, 2026 22:46
@csbobby
Copy link
Copy Markdown
Contributor Author

csbobby commented Apr 1, 2026 •
edited
Loading

Updated the modular prompts to adapt the recent llms.

@csbobby csbobby enabled auto-merge April 2, 2026 06:16
@csbobby csbobby disabled auto-merge April 2, 2026 06:18
@csbobby
Copy link
Copy Markdown
Contributor Author

csbobby commented Apr 2, 2026

Hi This passes the tests and ready to be reviewed @jakelorocco.

jakelorocco
jakelorocco reviewed Apr 2, 2026
View reviewed changes
Comment thread cli/decompose/decompose.py Outdated
@csbobby csbobby requested a review from jakelorocco April 6, 2026 15:16
planetf1
planetf1 reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few observations — mostly around parsing robustness and test coverage. Also worth checking whether the from e exception-chaining fix applied in _general_instructions.py is needed in any equivalent except blocks in _subtask_constraint_assign.py.

Comment thread cli/decompose/prompt_modules/subtask_constraint_assign/_subtask_constraint_assign.py
Comment thread cli/decompose/prompt_modules/subtask_constraint_assign/_subtask_constraint_assign.py Outdated
Comment thread docs/examples/m_decompose/decompose_using_cli.sh
#MODEL_ID=granite4:latest

MODEL_ID=qwen2.5:7b
MODEL_ID=mistral-small3.2:latest # granite4:latest
Copy link
Copy Markdown
Contributor

@planetf1 planetf1 Apr 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded model mistral-small3.2:latest —can we make it variable?
Is the model used documented in the test docs?
How much memory does it need? Is it reasonable on a smaller system (though if it's needed for results, understandable).

Copy link
Copy Markdown
Contributor Author

@csbobby csbobby Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a CLI example shell script and the variable MODEL_ID is configurable as an example here. We assume users will have their own scripts but the model is recommended with proper size and capacities.

Comment thread cli/decompose/prompt_modules/subtask_constraint_assign/_subtask_constraint_assign.py Outdated
Comment thread cli/decompose/prompt_modules/subtask_constraint_assign/_subtask_constraint_assign.py Outdated
Comment thread test/decompose/test_decompose.py
planetf1
planetf1 reviewed Apr 7, 2026
View reviewed changes
Comment thread docs/examples/m_decompose/python/python_decompose_example.py
@csbobby
Copy link
Copy Markdown
Contributor Author

csbobby commented Apr 9, 2026 •
edited
Loading

Hi Thedocs/examples/m_decompose/python/ is a tmp folder generated during the runtime (the model id there is generated by the variable model_id). The tmp folder should and will be removed in the next PR but just keeps now to avoid the merge conflict.

@csbobby csbobby requested a review from a team as a code owner April 9, 2026 16:11
@csbobby csbobby requested a review from nrfulton April 9, 2026 16:11
@csbobby csbobby force-pushed the tagparse branch 2 times, most recently from 02555b3 to 08fe688 Compare April 9, 2026 16:34
@csbobby csbobby requested review from planetf1 and removed request for nrfulton April 9, 2026 17:37
@jakelorocco jakelorocco added this pull request to the merge queue Apr 10, 2026
Merged via the queue into generative-computing:main with commit 315930f Apr 10, 2026
6 checks passed
@csbobby csbobby deleted the tagparse branch April 13, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakelorocco jakelorocco jakelorocco approved these changes

@planetf1 planetf1 Awaiting requested review from planetf1

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@csbobby @planetf1 @jakelorocco